Bug 58395 - Exceptions thrown from property getters called from Array prototype functions can be missed
Summary: Exceptions thrown from property getters called from Array prototype functions...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 16:42 PDT by Gavin Barraclough
Modified: 2011-06-07 13:29 PDT (History)
0 users

See Also:

Attachments
The patch (5.98 KB, patch)
2011-04-12 16:49 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-04-12 16:42:54 PDT 
This is caught by an ASSERT in the top of Interpreter::executeCall.

Check for exceptions after accessing properties that could be getters.
Comment 1 Gavin Barraclough 2011-04-12 16:49:47 PDT 
Created attachment 89308 [details]
The patch
Comment 2 Oliver Hunt 2011-04-12 17:00:43 PDT 
Comment on attachment 89308 [details]
The patch

r=me assuming perf is good
Comment 3 Gavin Barraclough 2011-04-12 17:13:56 PDT 
fixed in r83669