Bug 58392 - WebKit2: Frames prevent scrolling containing page
Summary: WebKit2: Frames prevent scrolling containing page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 16:18 PDT by Sam Weinig
Modified: 2011-04-12 17:20 PDT (History)
0 users

See Also:

Attachments
Patch (7.76 KB, patch)
2011-04-12 16:26 PDT, Sam Weinig 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-12 16:18:08 PDT 
WebKit2: Frames prevent scrolling containing page
Comment 1 Sam Weinig 2011-04-12 16:26:25 PDT 
Created attachment 89302 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-04-12 17:07:35 PDT 
Comment on attachment 89302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89302&action=review

> Source/WebCore/page/FrameView.cpp:144
> +            if (m_page->mainFrame() == m_frame) {

This test feels backwards.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:792
> +    if (fabsf(wheelEvent.deltaY()) >= fabsf(wheelEvent.deltaX())) {

Add a FIXME to fix this?
Comment 3 Sam Weinig 2011-04-12 17:20:16 PDT 
Committed r83672: <http://trac.webkit.org/changeset/83672>