WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 58392
WebKit2: Frames prevent scrolling containing page
https://bugs.webkit.org/show_bug.cgi?id=58392
Summary
WebKit2: Frames prevent scrolling containing page
Sam Weinig
Reported
2011-04-12 16:18:08 PDT
WebKit2: Frames prevent scrolling containing page
Attachments
Patch
(7.76 KB, patch)
2011-04-12 16:26 PDT
,
Sam Weinig
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2011-04-12 16:26:25 PDT
Created
attachment 89302
[details]
Patch
Simon Fraser (smfr)
Comment 2
2011-04-12 17:07:35 PDT
Comment on
attachment 89302
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=89302&action=review
> Source/WebCore/page/FrameView.cpp:144 > + if (m_page->mainFrame() == m_frame) {
This test feels backwards.
> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:792 > + if (fabsf(wheelEvent.deltaY()) >= fabsf(wheelEvent.deltaX())) {
Add a FIXME to fix this?
Sam Weinig
Comment 3
2011-04-12 17:20:16 PDT
Committed
r83672
: <
http://trac.webkit.org/changeset/83672
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug