Bug 58390 - Implement remaining Background and Mask css properties in CSSStyleApplyProperty
Summary: Implement remaining Background and Mask css properties in CSSStyleApplyProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 16:06 PDT by Luke Macpherson
Modified: 2011-04-13 17:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.40 KB, patch)
2011-04-12 16:08 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (18.24 KB, patch)
2011-04-12 17:06 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-04-12 16:06:08 PDT 
Implement remaining Background and Mask css properties in CSSStyleApplyProperty
Comment 1 Luke Macpherson 2011-04-12 16:08:01 PDT 
Created attachment 89298 [details]
Patch
Comment 2 Luke Macpherson 2011-04-12 17:06:13 PDT 
Created attachment 89309 [details]
Patch
Comment 3 WebKit Commit Bot 2011-04-12 22:13:00 PDT 
Comment on attachment 89309 [details]
Patch

Clearing flags on attachment: 89309

Committed r83700: <http://trac.webkit.org/changeset/83700>
Comment 4 WebKit Commit Bot 2011-04-12 22:13:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Andrey Kosyakov 2011-04-13 07:51:17 PDT 
Comment on attachment 89309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89309&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:78
> +    virtual void applyValue(CSSStyleSelector*, CSSValue*)

This broke chromium clang build due to missing const method modifier (causes shadowing base class method instead of overriding). Fixed in r83731.
Comment 6 Luke Macpherson 2011-04-13 17:12:48 PDT 
(In reply to comment #5)
> (From update of attachment 89309 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89309&action=review
> 
> > Source/WebCore/css/CSSStyleApplyProperty.cpp:78
> > +    virtual void applyValue(CSSStyleSelector*, CSSValue*)
> 
> This broke chromium clang build due to missing const method modifier (causes shadowing base class method instead of overriding). Fixed in r83731.

Well spotted. Thanks for the fix Andrey.