Bug 58389 - Make API callback objects use weak handles to run their finalizers
Summary: Make API callback objects use weak handles to run their finalizers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 16:05 PDT by Oliver Hunt
Modified: 2011-04-12 16:48 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.92 KB, patch)
2011-04-12 16:07 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-12 16:05:19 PDT
Make API callback objects use weak handles to run their finalizers
Comment 1 Oliver Hunt 2011-04-12 16:07:12 PDT
Created attachment 89297 [details]
Patch
Comment 2 Geoffrey Garen 2011-04-12 16:19:49 PDT
Comment on attachment 89297 [details]
Patch

When it becomes more common, we should find a way to make it easier and less error-prone to create a "finalize-only" style of handle.
Comment 3 Oliver Hunt 2011-04-12 16:28:05 PDT
Committed r83661: <http://trac.webkit.org/changeset/83661>
Comment 4 Geoffrey Garen 2011-04-12 16:48:16 PDT
Committed r83664: <http://trac.webkit.org/changeset/83664>