Bug 58386 - [chromium] Fix spellcheck regression in context menus
Summary: [chromium] Fix spellcheck regression in context menus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 15:54 PDT by John Abd-El-Malek
Modified: 2011-04-12 16:22 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2011-04-12 15:57 PDT, John Abd-El-Malek 		jianli: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2011-04-12 15:54:13 PDT 
[chromium] Fix spellcheck regression in context menus
Comment 1 John Abd-El-Malek 2011-04-12 15:57:53 PDT 
Created attachment 89292 [details]
Patch
Comment 2 John Abd-El-Malek 2011-04-12 15:58:45 PDT 
My original change was incorrect, since the offset is 0 when the first word is the one that's misspelt.  The length will be non-zero if there's a misspelling though, per WebSpellCheckClient comments.
Comment 3 John Abd-El-Malek 2011-04-12 16:22:23 PDT 
Committed r83660: <http://trac.webkit.org/changeset/83660>