WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58385
Allow WebView users to recreate dependent contexts after a context lost
https://bugs.webkit.org/show_bug.cgi?id=58385
Summary
Allow WebView users to recreate dependent contexts after a context lost
Antoine Labour
Reported
2011-04-12 15:50:44 PDT
Allow WebView users to recreate dependent contexts after a context lost
Attachments
Patch
(4.43 KB, patch)
2011-04-12 15:51 PDT
,
Antoine Labour
no flags
Details
Formatted Diff
Diff
Patch
(4.43 KB, patch)
2011-04-12 15:56 PDT
,
Antoine Labour
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Labour
Comment 1
2011-04-12 15:51:33 PDT
Created
attachment 89288
[details]
Patch
WebKit Review Bot
Comment 2
2011-04-12 15:53:12 PDT
Attachment 89288
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antoine Labour
Comment 3
2011-04-12 15:56:22 PDT
Created
attachment 89291
[details]
Patch
Kenneth Russell
Comment 4
2011-04-12 16:14:16 PDT
Comment on
attachment 89291
[details]
Patch This looks good to me. Alexey, do you have any comments?
Alexey Marinichev
Comment 5
2011-04-12 16:25:46 PDT
Looks good to me. My only comment is a general consistency, not related to this patch in particular. All other classes with graphicsContext3D method (WebGLRenderingContext, DrawingBuffer, SharedGraphicsContext3D) do not have any side-effects. It might end up being confusing.
Kenneth Russell
Comment 6
2011-04-12 17:14:02 PDT
Comment on
attachment 89291
[details]
Patch r=me
WebKit Commit Bot
Comment 7
2011-04-12 21:04:22 PDT
Comment on
attachment 89291
[details]
Patch Clearing flags on attachment: 89291 Committed
r83693
: <
http://trac.webkit.org/changeset/83693
>
WebKit Commit Bot
Comment 8
2011-04-12 21:04:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug