Bug 58385 - Allow WebView users to recreate dependent contexts after a context lost
Summary: Allow WebView users to recreate dependent contexts after a context lost
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 15:50 PDT by Antoine Labour
Modified: 2011-04-12 21:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.43 KB, patch)
2011-04-12 15:51 PDT, Antoine Labour
no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2011-04-12 15:56 PDT, Antoine Labour
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Labour 2011-04-12 15:50:44 PDT
Allow WebView users to recreate dependent contexts after a context lost
Comment 1 Antoine Labour 2011-04-12 15:51:33 PDT
Created attachment 89288 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-12 15:53:12 PDT
Attachment 89288 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antoine Labour 2011-04-12 15:56:22 PDT
Created attachment 89291 [details]
Patch
Comment 4 Kenneth Russell 2011-04-12 16:14:16 PDT
Comment on attachment 89291 [details]
Patch

This looks good to me. Alexey, do you have any comments?
Comment 5 Alexey Marinichev 2011-04-12 16:25:46 PDT
Looks good to me.

My only comment is a general consistency, not related to this patch in particular.  All other classes with graphicsContext3D method (WebGLRenderingContext, DrawingBuffer, SharedGraphicsContext3D) do not have any side-effects.  It might end up being confusing.
Comment 6 Kenneth Russell 2011-04-12 17:14:02 PDT
Comment on attachment 89291 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2011-04-12 21:04:22 PDT
Comment on attachment 89291 [details]
Patch

Clearing flags on attachment: 89291

Committed r83693: <http://trac.webkit.org/changeset/83693>
Comment 8 WebKit Commit Bot 2011-04-12 21:04:32 PDT
All reviewed patches have been landed.  Closing bug.