Bug 58371 - [chromium] Fix spelling layout tests since virtual function changed
Summary: [chromium] Fix spelling layout tests since virtual function changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 13:37 PDT by John Abd-El-Malek
Modified: 2011-04-12 16:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2011-04-12 13:37 PDT, John Abd-El-Malek 		no flags Details | Formatted Diff | Diff
Patch (1.97 KB, patch)
2011-04-12 15:49 PDT, John Abd-El-Malek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2011-04-12 13:37:01 PDT 
[chromium] Fix spelling layout tests since virtual function changed
Comment 1 John Abd-El-Malek 2011-04-12 13:37:23 PDT 
Created attachment 89264 [details]
Patch
Comment 2 Jian Li 2011-04-12 13:40:03 PDT 
Please also update ChangeLog.
Comment 3 Eric Seidel (no email) 2011-04-12 13:45:07 PDT 
ChangeLog fail.

also, strange commit message. :(

And failed to close the bug. :(

webkit-patch will do this all for you.  But I can understand that our tools can be confusing to those not familiar with them.
Comment 4 John Abd-El-Malek 2011-04-12 13:50:06 PDT 
(In reply to comment #3)
> ChangeLog fail.
> 
> also, strange commit message. :(
> 
> And failed to close the bug. :(
> 
> webkit-patch will do this all for you.  But I can understand that our tools can be confusing to those not familiar with them.

sorry, I was in a hurry to fix the build.  I thought it's ok to commit manually for tree fixes?

I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there.
Comment 5 Eric Seidel (no email) 2011-04-12 13:52:48 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > ChangeLog fail.
> > 
> > also, strange commit message. :(
> > 
> > And failed to close the bug. :(
> > 
> > webkit-patch will do this all for you.  But I can understand that our tools can be confusing to those not familiar with them.
> 
> sorry, I was in a hurry to fix the build.  I thought it's ok to commit manually for tree fixes?
> 
> I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there.

Understandable.  And yes, its certainly acceptable to commit build fixes w/o much process. We still generally have ChangeLogs for them.

Seems like you got bit by Chromium's DRT missing a ChangeLog.

Thanks for the quick fix.
Comment 6 John Abd-El-Malek 2011-04-12 15:49:23 PDT 
Created attachment 89287 [details]
Patch
Comment 7 John Abd-El-Malek 2011-04-12 15:50:30 PDT 
please ignore the latest patch, that was uploaded here by accident
Comment 8 Eric Seidel (no email) 2011-04-12 16:31:50 PDT 
Comment on attachment 89287 [details]
Patch

I'm sorry our tools have caused you so much trouble.  There is a bug about webkit-patch needing to warn people when uploading to closed patches.