Bug 58371 – [chromium] Fix spelling layout tests since virtual function changed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[John Abd-El-Malek]

[chromium] Fix spelling layout tests since virtual function changed

[John Abd-El-Malek]

Created attachment 89264 [details]
Patch

[Jian Li]

Please also update ChangeLog.

[Eric Seidel (no email)]

ChangeLog fail.

also, strange commit message. :(

And failed to close the bug. :(

webkit-patch will do this all for you.  But I can understand that our tools can be confusing to those not familiar with them.

[John Abd-El-Malek]

(In reply to comment #3)
> ChangeLog fail.
> 
> also, strange commit message. :(
> 
> And failed to close the bug. :(
> 
> webkit-patch will do this all for you.  But I can understand that our tools can be confusing to those not familiar with them.

sorry, I was in a hurry to fix the build.  I thought it's ok to commit manually for tree fixes?

I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there.

[Eric Seidel (no email)]

(In reply to comment #4)
> (In reply to comment #3)
> > ChangeLog fail.
> > 
> > also, strange commit message. :(
> > 
> > And failed to close the bug. :(
> > 
> > webkit-patch will do this all for you.  But I can understand that our tools can be confusing to those not familiar with them.
> 
> sorry, I was in a hurry to fix the build.  I thought it's ok to commit manually for tree fixes?
> 
> I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there.

Understandable.  And yes, its certainly acceptable to commit build fixes w/o much process. We still generally have ChangeLogs for them.

Seems like you got bit by Chromium's DRT missing a ChangeLog.

Thanks for the quick fix.

[John Abd-El-Malek]

Created attachment 89287 [details]
Patch

[John Abd-El-Malek]

please ignore the latest patch, that was uploaded here by accident

[Eric Seidel (no email)]

Comment on attachment 89287 [details]
Patch

I'm sorry our tools have caused you so much trouble.  There is a bug about webkit-patch needing to warn people when uploading to closed patches.