Bug 58344 - webkitpy.common.checkout.diff_parser errors when parsing SVN property changes
: webkitpy.common.checkout.diff_parser errors when parsing SVN property changes
Status: NEW
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-04-12 10:23 PST by
Modified: 2011-04-12 10:23 PST (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-04-12 10:23:59 PST
It seems that webkitpy.common.checkout.diff_parser doesn't know how to parse SVN property changes.

1. Apply the patch for bug #53625
2. Run, svn propset allow-tabs 1 Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl
3. Run, Tools/Scripts/webkit-patch land 53625

Then I received the following output:

dbatesRIM:WebKit dbates$ Tools/Scripts/webkit-patch land 53625

...

Fetching: https://bugs.webkit.org/show_bug.cgi?id=53625&ctype=xml
Guessing "Eric Seidel" as reviewer from attachment 89082 [details] on bug 53625.
WARNING: Patch's size is 22 kbytes.
Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time.
webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: ''
webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: 'Property changes on: Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl'
webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: '___________________________________________________________________'
webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: 'Added: allow-tabs'
webkitpy.common.checkout.diff_parser: [ERROR] Unexpected diff format when parsing a chunk: ''
Parsing ChangeLog: /Users/dbates/Desktop/WebKit/Tools/ChangeLog
Committed r83603: <http://trac.webkit.org/changeset/83603>
Updating bug 53625
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to continue...
...

In particular, notice the webkitpy.common.checkout.diff_parser errors.