Bug 58342 – Teach sub-selector chains about shadow descendants

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dimitri Glazkov (Google)]

In order to allow styling of the elements, exposed with shadow pseudo-element selector, we need to allow pseudo-classes and possibly other types of selectors (attribute selectors?) to be added at the end of the pseudo-elements.

[Dimitri Glazkov (Google)]

Created attachment 89928 [details]
Patch

[Dimitri Glazkov (Google)]

Created attachment 90207 [details]
Patch

[Dimitri Glazkov (Google)]

Antti, can you take a look?

[Dimitri Glazkov (Google)]

Bueller?

[Antti Koivisto]

Comment on attachment 90207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90207&action=review

r=me

> Source/WebCore/css/CSSParserValues.h:119
>      bool isSimple() const { return !m_tagHistory && m_selector->isSimple(); }
> +    bool hasShadowDescendant() const;

inline like the others?

[Dimitri Glazkov (Google)]

(In reply to comment #5)
> (From update of attachment 90207 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90207&action=review
> 
> r=me
> 
> > Source/WebCore/css/CSSParserValues.h:119
> >      bool isSimple() const { return !m_tagHistory && m_selector->isSimple(); }
> > +    bool hasShadowDescendant() const;
> 
> inline like the others?

Sure thing!

[Dimitri Glazkov (Google)]

Committed r85077: <http://trac.webkit.org/changeset/85077>