Bug 58342 - Teach sub-selector chains about shadow descendants
Summary: Teach sub-selector chains about shadow descendants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 58341 52962
  Show dependency treegraph
 
Reported: 2011-04-12 10:21 PDT by Dimitri Glazkov (Google)
Modified: 2011-04-27 13:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.27 KB, patch)
2011-04-16 11:19 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch (15.26 KB, patch)
2011-04-19 08:44 PDT, Dimitri Glazkov (Google)
koivisto: review+
koivisto: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-04-12 10:21:55 PDT
In order to allow styling of the elements, exposed with shadow pseudo-element selector, we need to allow pseudo-classes and possibly other types of selectors (attribute selectors?) to be added at the end of the pseudo-elements.
Comment 1 Dimitri Glazkov (Google) 2011-04-16 11:19:49 PDT
Created attachment 89928 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-04-19 08:44:53 PDT
Created attachment 90207 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2011-04-19 20:10:02 PDT
Antti, can you take a look?
Comment 4 Dimitri Glazkov (Google) 2011-04-20 15:24:20 PDT
Bueller?
Comment 5 Antti Koivisto 2011-04-26 04:11:49 PDT
Comment on attachment 90207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90207&action=review

r=me

> Source/WebCore/css/CSSParserValues.h:119
>      bool isSimple() const { return !m_tagHistory && m_selector->isSimple(); }
> +    bool hasShadowDescendant() const;

inline like the others?
Comment 6 Dimitri Glazkov (Google) 2011-04-27 11:37:22 PDT
(In reply to comment #5)
> (From update of attachment 90207 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90207&action=review
> 
> r=me
> 
> > Source/WebCore/css/CSSParserValues.h:119
> >      bool isSimple() const { return !m_tagHistory && m_selector->isSimple(); }
> > +    bool hasShadowDescendant() const;
> 
> inline like the others?

Sure thing!
Comment 7 Dimitri Glazkov (Google) 2011-04-27 13:32:25 PDT
Committed r85077: <http://trac.webkit.org/changeset/85077>