WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 58340
Web Inspector: another pass of protocol renames.
https://bugs.webkit.org/show_bug.cgi?id=58340
Summary
Web Inspector: another pass of protocol renames.
Pavel Feldman
Reported
2011-04-12 10:10:23 PDT
Debugger, Network and DOM events look reasonable to me after this change.
Attachments
Patch
(23.07 KB, patch)
2011-04-12 23:56 PDT
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2011-04-12 23:56:40 PDT
Created
attachment 89345
[details]
Patch
Yury Semikhatsky
Comment 2
2011-04-13 00:02:52 PDT
Comment on
attachment 89345
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=89345&action=review
> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:56 > + injectedScript.evaluate(errorString, expression, objectGroup ? *objectGroup : "", includeCommandLineAPI ? *includeCommandLineAPI : false, result);
Conversions like objectGroup ? *objectGroup : "" can well be made in generated dispatcher code, that would simplify agents code a bit.
Pavel Feldman
Comment 3
2011-04-13 00:04:37 PDT
Committed
r83706
: <
http://trac.webkit.org/changeset/83706
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug