Bug 58334 - LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
Summary: LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 09:13 PDT by Brady Eidson
Modified: 2011-12-27 16:00 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-04-12 09:13:41 PDT
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2

All such tests use both computedStyleIncludingVisitedInfo and keepWebHistory, both of which *are* implemented in WKTR.

However, something must not be working right.  Currently the 4 known failures due to this bug are:
fast/history/nested-visited-test.html
fast/history/self-is-visited.html
fast/history/sibling-visited-test.html
state-url-sets-links-visited.html

All of these visually pass in a WK2 browser.

The failures all involve the returned style for the inspected nodes not correctly showing their visitedness.

Two obvious theories:
1 - computedStyleIncludingVisitedInfo doesn't work right
2 - Visited links go through a round trip to the UIProcess and don't get back to the WebProcess in time, therefore we're being bitten by IPC asynchronicity
Comment 1 Brady Eidson 2011-04-12 09:22:41 PDT
Added a new failing test to the skipped list and reclassified the 3 others in r83595
Comment 2 Samuel White 2011-12-27 07:38:13 PST
platform/mac/accessibility/search-predicate.html was added to the skipped list in r103704. It fails because visited links are not properly reported as visited in WK2 and do not report the appropriate style change.
Comment 3 Brady Eidson 2011-12-27 16:00:52 PST
(In reply to comment #2)
> platform/mac/accessibility/search-predicate.html was added to the skipped list in r103704. It fails because visited links are not properly reported as visited in WK2 and do not report the appropriate style change.

To the end user visited links work fine in WebKit 2.  See my original hypothesis from 2011-4-12:

>1 - computedStyleIncludingVisitedInfo doesn't work right
>2 - Visited links go through a round trip to the UIProcess and don't get back to the WebProcess in time, therefore we're being bitten by IPC asynchronicity