RESOLVED INVALID 58329
Web Inspector: ResourceView.createResourceView should return ResourceView instance. 
https://bugs.webkit.org/show_bug.cgi?id=58329
Summary Web Inspector: ResourceView.createResourceView should return ResourceView ins...
Pavel Podivilov
Reported 2011-04-12 08:51:33 PDT
Web Inspector: ResourceView.createResourceView should return ResourceView instance.
Attachments
Patch. (8.69 KB, patch)
2011-04-12 08:52 PDT, Pavel Podivilov 		pfeldman: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-04-12 08:52:15 PDT
Created attachment 89209 [details] Patch.
Pavel Feldman
Comment 2 2011-04-12 09:17:53 PDT
Comment on attachment 89209 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89209&action=review > Source/WebCore/inspector/front-end/ResourceView.js:61 > + this._sourceFrame.show(parentElement); Why do we need the show / hide logic in the SourceFrame now? Can we use the same view in the scripts panel instead? > Source/WebCore/inspector/front-end/SourceFrame.js:42 > + this._view = new WebInspector.View(); Why do you need this? I thought we agreed that there should be no SourceFrame -> View dependency.
Note You need to log in before you can comment on or make changes to this bug.