Bug 58329 - Web Inspector: ResourceView.createResourceView should return ResourceView instance.
Summary: Web Inspector: ResourceView.createResourceView should return ResourceView ins...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 08:51 PDT by Pavel Podivilov
Modified: 2011-04-12 09:40 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (8.69 KB, patch)
2011-04-12 08:52 PDT, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-04-12 08:51:33 PDT 
Web Inspector: ResourceView.createResourceView should return ResourceView instance.
Comment 1 Pavel Podivilov 2011-04-12 08:52:15 PDT 
Created attachment 89209 [details]
Patch.
Comment 2 Pavel Feldman 2011-04-12 09:17:53 PDT 
Comment on attachment 89209 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=89209&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:61
> +        this._sourceFrame.show(parentElement);

Why do we need the show / hide logic in the SourceFrame now? Can we use the same view in the scripts panel instead?

> Source/WebCore/inspector/front-end/SourceFrame.js:42
> +    this._view = new WebInspector.View();

Why do you need this? I thought we agreed that there should be no SourceFrame -> View dependency.