Bug 58324 - Web Inspector: remove scriptWorldType from the protocol.
Summary: Web Inspector: remove scriptWorldType from the protocol.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 08:28 PDT by Pavel Feldman
Modified: 2011-04-12 10:07 PDT (History)
12 users (show)

See Also:

Attachments
Patch (14.45 KB, patch)
2011-04-12 08:50 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[PATCH] that compiles. (15.43 KB, patch)
2011-04-12 09:14 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-12 08:28:32 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-04-12 08:50:49 PDT 
Created attachment 89208 [details]
Patch
Comment 2 Early Warning System Bot 2011-04-12 09:02:51 PDT 
Attachment 89208 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8391424
Comment 3 Pavel Feldman 2011-04-12 09:14:55 PDT 
Created attachment 89212 [details]
[PATCH] that compiles.
Comment 4 Build Bot 2011-04-12 09:32:56 PDT 
Attachment 89208 [details] did not build on win:
Build output: http://queues.webkit.org/results/8395096
Comment 5 Yury Semikhatsky 2011-04-12 10:01:17 PDT 
Comment on attachment 89212 [details]
[PATCH] that compiles.

View in context: https://bugs.webkit.org/attachment.cgi?id=89212&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:247
> +    return true;

return (currentWorld(exec) != mainThreadNormalWorld()); ?

> Source/WebCore/bindings/v8/DebuggerScript.js:80
> +        isContentScript: script.context_data && script.context_data.indexOf("injected") == 0

Please cast the expression to boolean explicitly to avoid surprises when it's an undefined and is casted ToBoolean() in ScriptDebugServer.cpp.
Comment 6 Pavel Feldman 2011-04-12 10:07:50 PDT 
Committed r83601: <http://trac.webkit.org/changeset/83601>