Bug 58322 – Web Inspector: Web Page Performance auditing fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

1. Navigate to cnn.com and open inspector
2. Go to Audits tab and click on Run

What is the expected output? 
Auditing should finish and load the data

What do you see instead?
Auditing doesn't finish. If Web Page Performance is disabled, auditing is completed.
Auditing on google.com and yahoo.com works fine though.

Upstreaming Chromium issue http://code.google.com/p/chromium/issues/detail?id=78473

[Alexander Pavlov (apavlov)]

Created attachment 89207 [details]
[PATCH] Suggested fix

[Alexander Pavlov (apavlov)]

Created attachment 89227 [details]
[PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look)

[Pavel Feldman]

Comment on attachment 89227 [details]
[PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look)

View in context: https://bugs.webkit.org/attachment.cgi?id=89227&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:362
> +                    WebInspector.domAgent.querySelector(document.id, selectors[i], queryCallback.bind(null, i === selectors.length - 1 ? selectorsCallback.bind(null, callback, styleSheets, testedSelectors) : null, selectors[i], styleSheets, testedSelectors));

You should requestDocument within DOMAgent.js::querySelector instead. I thought Andrey has fixed it already - he had a patch pending.
Also I can't parse this string - you should extract variables for bound functions, etc.

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/audits/audits-panel-functional.html
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/AuditRules.js
Committed r83716