Bug 58315 - REGRESSION (r81479): generate-inspector-idl fails on native win32
Summary: REGRESSION (r81479): generate-inspector-idl fails on native win32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 56294
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-12 05:37 PDT by Patrick R. Gansterer
Modified: 2011-04-18 04:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2011-04-17 10:23 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-04-12 05:37:48 PDT 
generate-inspector-idl fails if Inspector.json contains carriage return characters.
You get them if you use a _git_ checkout with autocrlf enabled.
To solve this we can:
a) Add "-crlf" git attribute in ".gitattributes"
b) Replace '\r\n' before passing the content to eval
c) Use a JSON parser
Comment 1 Patrick R. Gansterer 2011-04-17 10:23:07 PDT 
Created attachment 89950 [details]
Patch
Comment 2 WebKit Commit Bot 2011-04-18 04:27:12 PDT 
The commit-queue encountered the following flaky tests while processing attachment 89950 [details]:

http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-04-18 04:29:31 PDT 
Comment on attachment 89950 [details]
Patch

Clearing flags on attachment: 89950

Committed r84130: <http://trac.webkit.org/changeset/84130>
Comment 4 WebKit Commit Bot 2011-04-18 04:29:35 PDT 
All reviewed patches have been landed.  Closing bug.