Bug 58311 - Member field in PluginView for efl port is not initialized
Summary: Member field in PluginView for efl port is not initialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 02:28 PDT by Mariusz Grzegorczyk
Modified: 2011-04-20 08:42 PDT (History)
7 users (show)

See Also:

Attachments
Initializing of m_window member field in PluginView's constructor for efl port (1.15 KB, patch)
2011-04-12 02:33 PDT, Mariusz Grzegorczyk 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Initializing of m_window member field in PluginView's constructor for efl port (1.18 KB, patch)
2011-04-20 02:02 PDT, Mariusz Grzegorczyk 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mariusz Grzegorczyk 2011-04-12 02:28:28 PDT 
Initialize m_window member field for efl port in constructor.
Comment 1 Mariusz Grzegorczyk 2011-04-12 02:33:06 PDT 
Created attachment 89180 [details]
Initializing of m_window member field in PluginView's constructor for efl port
Comment 2 Eric Seidel (no email) 2011-04-12 10:55:35 PDT 
Comment on attachment 89180 [details]
Initializing of m_window member field in PluginView's constructor for efl port

View in context: https://bugs.webkit.org/attachment.cgi?id=89180&action=review

OK.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This prevents the CQ from landing yoru patch.  You should have replaced this with a string saying how testing isn't needed/possible for this patch.
Comment 3 Mariusz Grzegorczyk 2011-04-20 02:02:41 PDT 
Created attachment 90323 [details]
Initializing of m_window member field in PluginView's constructor for efl port
Comment 4 Andreas Kling 2011-04-20 05:51:52 PDT 
Comment on attachment 90323 [details]
Initializing of m_window member field in PluginView's constructor for efl port

Sure.
Comment 5 WebKit Commit Bot 2011-04-20 06:20:50 PDT 
Comment on attachment 90323 [details]
Initializing of m_window member field in PluginView's constructor for efl port

Clearing flags on attachment: 90323

Committed r84362: <http://trac.webkit.org/changeset/84362>
Comment 6 WebKit Commit Bot 2011-04-20 06:20:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-04-20 08:42:17 PDT 
http://trac.webkit.org/changeset/84362 might have broken GTK Linux 32-bit Debug