Bug 58307 - [GStreamer] some public callbacks remain
Summary: [GStreamer] some public callbacks remain
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 01:57 PDT by Philippe Normand
Modified: 2011-04-12 09:37 PDT (History)
0 users

See Also:

Attachments
proposed patch (19.63 KB, patch)
2011-04-12 03:02 PDT, Philippe Normand 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-04-12 01:57:09 PDT 
We should make those static in the cpp file:

mediaPlayerPrivateMessageCallback
mediaPlayerPrivateRepaintCallback
mediaPlayerPrivateSourceChangedCallback
Comment 1 Philippe Normand 2011-04-12 03:02:20 PDT 
Created attachment 89182 [details]
proposed patch
Comment 2 Alexis Menard (darktears) 2011-04-12 05:46:03 PDT 
Comment on attachment 89182 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89182&action=review

Otherwise the patch looks good for me. It makes the code easier to read.

> Source/WebCore/ChangeLog:5
> +        [GStreamer] some public callbacks remain

Shouldn't you put a uper case letter after [GStreamer]
Comment 3 Martin Robinson 2011-04-12 07:30:53 PDT 
Comment on attachment 89182 [details]
proposed patch

Nice cleanup.
Comment 4 Philippe Normand 2011-04-12 09:37:26 PDT 
Committed r83598: <http://trac.webkit.org/changeset/83598>