Bug 58297 - [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
Summary: [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2011-04-11 20:42 PDT by Gustavo Noronha (kov)
Modified: 2011-04-13 07:05 PDT (History)
4 users (show)

See Also:

Patch (3.85 KB, patch)
2011-04-11 20:49 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2011-04-11 20:42:19 PDT
Currently we have code in GtkLauncher and Epiphany to disable Flash. But flash is not the only plugin using GTK+ 2 symbols, and users may actually be using something like nspluginwrapper that shields the main browser process from the plugin. The opposite situation will eventually happen as well: WebKitGTK+ built with GTK+ 2 will encounter plugins using GTK+ 3. So we should be smarter and only disable plugins when we detect they use symbols from a different GTK+ version on them.
Comment 1 Gustavo Noronha (kov) 2011-04-11 20:49:50 PDT
Created attachment 89153 [details]
Comment 2 Gustavo Noronha (kov) 2011-04-11 20:53:11 PDT
FWIW, it correctly ignores flash and java, and correctly loads flash through nspluginwrapper on my system =).
Comment 3 Martin Robinson 2011-04-12 17:26:08 PDT
Comment on attachment 89153 [details]

Comment 4 WebKit Commit Bot 2011-04-13 07:05:53 PDT
Comment on attachment 89153 [details]

Clearing flags on attachment: 89153

Committed r83728: <http://trac.webkit.org/changeset/83728>
Comment 5 WebKit Commit Bot 2011-04-13 07:05:59 PDT
All reviewed patches have been landed.  Closing bug.