WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58297
[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
https://bugs.webkit.org/show_bug.cgi?id=58297
Summary
[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols ...
Gustavo Noronha (kov)
Reported
2011-04-11 20:42:19 PDT
Currently we have code in GtkLauncher and Epiphany to disable Flash. But flash is not the only plugin using GTK+ 2 symbols, and users may actually be using something like nspluginwrapper that shields the main browser process from the plugin. The opposite situation will eventually happen as well: WebKitGTK+ built with GTK+ 2 will encounter plugins using GTK+ 3. So we should be smarter and only disable plugins when we detect they use symbols from a different GTK+ version on them.
Attachments
Patch
(3.85 KB, patch)
2011-04-11 20:49 PDT
,
Gustavo Noronha (kov)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1
2011-04-11 20:49:50 PDT
Created
attachment 89153
[details]
Patch
Gustavo Noronha (kov)
Comment 2
2011-04-11 20:53:11 PDT
FWIW, it correctly ignores flash and java, and correctly loads flash through nspluginwrapper on my system =).
Martin Robinson
Comment 3
2011-04-12 17:26:08 PDT
Comment on
attachment 89153
[details]
Patch Excellent.
WebKit Commit Bot
Comment 4
2011-04-13 07:05:53 PDT
Comment on
attachment 89153
[details]
Patch Clearing flags on attachment: 89153 Committed
r83728
: <
http://trac.webkit.org/changeset/83728
>
WebKit Commit Bot
Comment 5
2011-04-13 07:05:59 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug