Bug 58289 - On Solaris 10 with SS12 compiler, TCMalloc_PageHeap::runScavengerThread(void* context) is expected to return a value
Summary: On Solaris 10 with SS12 compiler, TCMalloc_PageHeap::runScavengerThread(void*...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 17:01 PDT by Ben Taylor
Modified: 2011-04-11 22:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch to fix compile issue with Solaris 10 and Studio 12 CC, this code expects to return a value. (1.37 KB, patch)
2011-04-11 18:18 PDT, Ben Taylor 		no flags Details | Formatted Diff | Diff
Updated patch that fixes the currently broken white space issue. (1.41 KB, patch)
2011-04-11 18:31 PDT, Ben Taylor 		no flags Details | Formatted Diff | Diff
Updated patch that fixes the currently broken white space issue, and trailing ) (1.41 KB, patch)
2011-04-11 20:23 PDT, Ben Taylor 		no flags Details | Formatted Diff | Diff
patch that fixes the issues, and passes check-webkit-style locally (1.46 KB, patch)
2011-04-11 20:48 PDT, Ben Taylor 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Taylor 2011-04-11 17:01:59 PDT 
wtf/FastMalloc.cpp fails to compile on Solaris 10 with SS12 C++ compiler with the following error:

"wtf/FastMalloc.cpp", line 1502: Error: "static WTF::TCMalloc_PageHeap::runScavengerThread(void*)" is expected to return a value.
Comment 1 Ben Taylor 2011-04-11 18:18:56 PDT 
Created attachment 89138 [details]
Patch to fix compile issue with Solaris 10 and Studio 12 CC, this code expects to return a value.

Patch to fix the compile issue on Solaris 10 with Sun Studio 12 CC
Comment 2 WebKit Review Bot 2011-04-11 18:21:30 PDT 
Attachment 89138 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/FastMalloc.cpp:1623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ben Taylor 2011-04-11 18:31:39 PDT 
Created attachment 89141 [details]
Updated patch that fixes the currently broken white space issue.

Note to self. Simple fixes - run check-webkit-style.  Missed the 2-space indent originally in the source.
Comment 4 Ben Taylor 2011-04-11 20:23:48 PDT 
Created attachment 89150 [details]
Updated patch that fixes the currently broken white space issue, and trailing )

Fixed now.
Comment 5 Ben Taylor 2011-04-11 20:48:46 PDT 
Created attachment 89152 [details]
patch that fixes the issues, and passes check-webkit-style locally

This should do it.
Comment 6 Alexey Proskuryakov 2011-04-11 22:04:28 PDT 
Comment on attachment 89152 [details]
patch that fixes the issues, and passes check-webkit-style locally

Honestly, I don't understand why we don't just always have this "return 0".

+#if (COMPILER(MSVC) || COMPILER(SUNCC))

Unneeded parentheses here.
Comment 7 WebKit Commit Bot 2011-04-11 22:38:04 PDT 
The commit-queue encountered the following flaky tests while processing attachment 89152 [details]:

java/lc3/JavaObject/JavaObjectToInt-002-n.html bug 58299 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2011-04-11 22:40:23 PDT 
Comment on attachment 89152 [details]
patch that fixes the issues, and passes check-webkit-style locally

Clearing flags on attachment: 89152

Committed r83557: <http://trac.webkit.org/changeset/83557>
Comment 9 WebKit Commit Bot 2011-04-11 22:40:30 PDT 
All reviewed patches have been landed.  Closing bug.