Bug 58285 – CompositeAnimation is cleared while an AnimationBase is waiting for notification

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dean Jackson]

<rdar://problem/9243181>
<rdar://problem/9241918>
<rdar://problem/9239320>

From Apple crash reporter, multiple instances of the AnimationControllerPrivate sending out notifications to animations that no longer have a valid CompositeAnimation.

[Dean Jackson]

Created attachment 89121 [details]
Patch

[WebKit Review Bot]

Attachment 89121 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/animation/AnimationBase.cpp:932:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1205:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1264:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1378:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1402:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Created attachment 89124 [details]
Patch

Must have passed wrong args to check-webkit-style :(

[Simon Fraser (smfr)]

Comment on attachment 89124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89124&action=review

> Source/WebCore/page/animation/AnimationBase.cpp:929
> +    // Exit if we have no CompositeAnimation

This and all the other same comments are not useful. The code says it.

[Dean Jackson]

http://trac.webkit.org/changeset/83542