Bug 58285 - CompositeAnimation is cleared while an AnimationBase is waiting for notification
Summary: CompositeAnimation is cleared while an AnimationBase is waiting for notification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-11 16:33 PDT by Dean Jackson
Modified: 2011-04-11 17:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.08 KB, patch)
2011-04-11 16:55 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (6.03 KB, patch)
2011-04-11 17:01 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2011-04-11 16:33:44 PDT
<rdar://problem/9243181>
<rdar://problem/9241918>
<rdar://problem/9239320>

From Apple crash reporter, multiple instances of the AnimationControllerPrivate sending out notifications to animations that no longer have a valid CompositeAnimation.
Comment 1 Dean Jackson 2011-04-11 16:55:09 PDT
Created attachment 89121 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-11 16:56:56 PDT
Attachment 89121 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/animation/AnimationBase.cpp:932:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1205:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1264:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1378:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/page/animation/AnimationBase.cpp:1402:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dean Jackson 2011-04-11 17:01:00 PDT
Created attachment 89124 [details]
Patch

Must have passed wrong args to check-webkit-style :(
Comment 4 Simon Fraser (smfr) 2011-04-11 17:09:00 PDT
Comment on attachment 89124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89124&action=review

> Source/WebCore/page/animation/AnimationBase.cpp:929
> +    // Exit if we have no CompositeAnimation

This and all the other same comments are not useful. The code says it.
Comment 5 Dean Jackson 2011-04-11 17:39:10 PDT
http://trac.webkit.org/changeset/83542