WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58263
Use EncodedValueDescriptor on both JSVALUE32_64, JSVALUE64.
https://bugs.webkit.org/show_bug.cgi?id=58263
Summary
Use EncodedValueDescriptor on both JSVALUE32_64, JSVALUE64.
Gavin Barraclough
Reported
2011-04-11 13:29:25 PDT
The JSJITInterface already uses EncodedValueDescriptor to access the tag/payload separately on JSVALUE64, even though EncodedValueDescriptor is not used in JSVALUE64's implementation of JSValue. Remove the separate definition for m_ptr on X86_64. Using the union allows us to remove a layer of makeImmediate()/immedaiteValue() methods.
Attachments
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2011-04-11 15:18:41 PDT
fixed in
r83517
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug