Bug 58260 - [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
Summary: [chromium]: Get the list of misspelled words in the WebKit code insetad of in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 13:12 PDT by John Abd-El-Malek
Modified: 2011-04-12 11:46 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.64 KB, patch)
2011-04-11 13:12 PDT, John Abd-El-Malek 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2011-04-11 13:12:23 PDT 
[chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
Comment 1 John Abd-El-Malek 2011-04-11 13:12:51 PDT 
Created attachment 89062 [details]
Patch
Comment 2 John Abd-El-Malek 2011-04-11 13:15:55 PDT 
The Chrome side change is http://codereview.chromium.org/6813090/.  The motivation is to get rid of the remaining code in render_view.cc which deals with spellchecking.  Since all the code that uses it is in WebKit, with Chrome providing the implementation backend, I moved the little remaining code out to WebKit.
Comment 3 Darin Fisher (:fishd, Google) 2011-04-12 09:30:01 PDT 
Comment on attachment 89062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89062&action=review

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:269
> +

nit: kill this extra new line
Comment 4 John Abd-El-Malek 2011-04-12 11:46:08 PDT 
Committed r83617: <http://trac.webkit.org/changeset/83617>