WebKit2: links don’t update to look visited
Created attachment 89043 [details] Patch
Comment on attachment 89043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89043&action=review > Source/WebKit2/WebProcess/WebProcess.cpp:281 > + for (size_t i = 0; i < linkHashes.size(); ++i) { > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it = m_pageGroupMap.begin(); > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end = m_pageGroupMap.end(); > + for (; it != end; ++it) > + Page::visitedStateChanged(PageGroup::pageGroup(it->second->identifier()), linkHashes[i]); > + } Could you add a FIXME here specifying that we might not want to track visited links per context but per page group? > Source/WebKit2/WebProcess/WebProcess.cpp:289 > - Page::allVisitedStateChanged(sharedPageGroup()); > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it = m_pageGroupMap.begin(); > + HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end = m_pageGroupMap.end(); > + for (; it != end; ++it) > + Page::allVisitedStateChanged(PageGroup::pageGroup(it->second->identifier())); Ditto.
Fixed in r83472.