RESOLVED FIXED 58251
[Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file. 
https://bugs.webkit.org/show_bug.cgi?id=58251
Summary [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public...
Alexis Menard (darktears)
Reported 2011-04-11 11:49:35 PDT
QWebFrame contains : private Q_SLOTS: void orientationChanged(); This does not follow Qt coding conventions where private slots should be in the private implementation of the class. It may block us to do rename of the slots, refactoring or even delete it.
Attachments
Proposed patch. (2.87 KB, patch)
2011-04-11 11:53 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-04-11 11:53:30 PDT
Created attachment 89042 [details] Proposed patch.
WebKit Commit Bot
Comment 2 2011-04-11 15:14:40 PDT
Comment on attachment 89042 [details] Proposed patch. Clearing flags on attachment: 89042 Committed r83512: <http://trac.webkit.org/changeset/83512>
WebKit Commit Bot
Comment 3 2011-04-11 15:14:45 PDT
All reviewed patches have been landed. Closing bug.
Alexis Menard (darktears)
Comment 4 2011-04-12 05:00:50 PDT
Committed r83579: <http://trac.webkit.org/changeset/83579>
Note You need to log in before you can comment on or make changes to this bug.