Bug 58251 - [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
Summary: [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-11 11:49 PDT by Alexis Menard (darktears)
Modified: 2011-05-04 12:59 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch. (2.87 KB, patch)
2011-04-11 11:53 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-04-11 11:49:35 PDT 
QWebFrame contains :

private Q_SLOTS:
void orientationChanged();

This does not follow Qt coding conventions where private slots should be in the private implementation of the class. It may block us to do rename of the slots, refactoring or even delete it.
Comment 1 Alexis Menard (darktears) 2011-04-11 11:53:30 PDT 
Created attachment 89042 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2011-04-11 15:14:40 PDT 
Comment on attachment 89042 [details]
Proposed patch.

Clearing flags on attachment: 89042

Committed r83512: <http://trac.webkit.org/changeset/83512>
Comment 3 WebKit Commit Bot 2011-04-11 15:14:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexis Menard (darktears) 2011-04-12 05:00:50 PDT 
Committed r83579: <http://trac.webkit.org/changeset/83579>