Bug 58250 – Rename MediaControls to MediaControlRootElement.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

Rename MediaControls to MediaControlRootElement.

[Dimitri Glazkov (Google)]

Created attachment 89040 [details]
Needs full bake on EWS.

[Eric Carlson]

Comment on attachment 89040 [details]
Needs full bake on EWS.

View in context: https://bugs.webkit.org/attachment.cgi?id=89040&action=review

> Tools/ChangeLog:9
> [phone]  Dimitri Glazkov  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Rename MediaControls to MediaControlRootElement.
> +        https://bugs.webkit.org/show_bug.cgi?id=58250
> +
> +        * Scripts/do-webcore-rename:
> +

Oops?

> Tools/Scripts/do-webcore-rename:100
> -    "DocLoader" => "CachedResourceLoader",
> +    "MediaControls" => "MediaControlRootElement",

Oops, did you really mean to check this in?

[Dimitri Glazkov (Google)]

(In reply to comment #2)
> (From update of attachment 89040 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89040&action=review
> 
> > Tools/ChangeLog:9
> > [phone]  Dimitri Glazkov  <[e-mail]>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Rename MediaControls to MediaControlRootElement.
> > +        https://bugs.webkit.org/show_bug.cgi?id=58250
> > +
> > +        * Scripts/do-webcore-rename:
> > +
> 
> Oops?
> 
> > Tools/Scripts/do-webcore-rename:100
> > -    "DocLoader" => "CachedResourceLoader",
> > +    "MediaControls" => "MediaControlRootElement",
> 
> Oops, did you really mean to check this in?

I know it looks weird, but that's how we're supposed to do it. Each rename also commits the change here, so that you can easily see what's been renamed using this tool: http://trac.webkit.org/log/trunk/Tools/Scripts/do-webcore-rename

[Eric Carlson]

(In reply to comment #3)
> I know it looks weird, but that's how we're supposed to do it. Each rename also commits 
> the change here, so that you can easily see what's been renamed using this tool: 
> http://trac.webkit.org/log/trunk/Tools/Scripts/do-webcore-rename

Hah, I learned something new today.

[WebKit Commit Bot]

Comment on attachment 89040 [details]
Needs full bake on EWS.

Rejecting attachment 89040 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
/WebCore/rendering/MediaControlElements.h
patching file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/public/WebContextMenuData.h
patching file Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/do-webcore-rename

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8392085

[Dimitri Glazkov (Google)]

Committed r83545: <http://trac.webkit.org/changeset/83545>