Adjust padding for input and combos
Created attachment 89036 [details] Screenshot
Created attachment 89044 [details] Screenshot after patch
Created attachment 89045 [details] Patch
Comment on attachment 89045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89045&action=review > Source/WebCore/platform/qt/RenderThemeQt.cpp:109 > +static const float defaultButtonPaddingLeft = 18; I am not sure the default is really needed here. We could also put them in an anomymous namespace so that they are only visible here. Info here: http://msdn.microsoft.com/en-us/library/yct4x9k5(v=vs.80).aspx : You can declare an unnamed namespace as a superior alternative to the use of global static variable declarations. > Source/WebCore/platform/qt/RenderThemeQt.cpp:113 > +static const float defaultComboBoxPadding = 9; As it is the selector element, combobox might not be the best name
Created attachment 89103 [details] Patch 2
Comment on attachment 89103 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=89103&action=review I assume this doesnt break current non mobile theme theming > Source/WebCore/platform/qt/RenderThemeQt.cpp:108 > +// Values to mobile theme padding s/to/for - but useless comment :-) just remove
Committed at r83615