Bug 58240 - Web Inspector: document console domain, support cross-domain type references.
Summary: Web Inspector: document console domain, support cross-domain type references.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 09:24 PDT by Pavel Feldman
Modified: 2011-04-12 04:36 PDT (History)
10 users (show)

See Also:


Attachments
Patch (21.93 KB, patch)
2011-04-11 09:29 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-11 09:24:25 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-11 09:29:40 PDT
Created attachment 89014 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-12 04:33:33 PDT
Comment on attachment 89014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89014&action=review

> Source/WebCore/inspector/ConsoleMessage.cpp:114
> +    case NetworkErrorMessageType: return "networkError";

These constants need refactoring. Worth a separate change though.
Comment 3 Pavel Feldman 2011-04-12 04:36:14 PDT
Comment on attachment 89014 [details]
Patch

Clearing flags on attachment: 89014

Committed r83575: <http://trac.webkit.org/changeset/83575>
Comment 4 Pavel Feldman 2011-04-12 04:36:24 PDT
All reviewed patches have been landed.  Closing bug.