Bug 58231 - Web Inspector: fix source mapping for deobfuscated scripts.
Summary: Web Inspector: fix source mapping for deobfuscated scripts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 06:21 PDT by Pavel Podivilov
Modified: 2011-04-13 15:17 PDT (History)
11 users (show)

See Also:

Attachments
Patch. (6.10 KB, patch)
2011-04-11 06:22 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Added test. (11.26 KB, patch)
2011-04-12 05:49 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Add test. (11.24 KB, patch)
2011-04-12 09:51 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-04-11 06:21:45 PDT 
Web Inspector: fix source mapping for deobfuscated scripts.

Existing source mapping appears to be inaccurate in some cases. New regexp would have much more matches, thus providing more accurate mapping.
Comment 1 Pavel Podivilov 2011-04-11 06:22:18 PDT 
Created attachment 89000 [details]
Patch.
Comment 2 Pavel Feldman 2011-04-11 22:04:58 PDT 
Comment on attachment 89000 [details]
Patch.

Can this be tested?
Comment 3 Pavel Podivilov 2011-04-12 05:49:38 PDT 
Created attachment 89190 [details]
Added test.
Comment 4 Pavel Podivilov 2011-04-12 09:51:25 PDT 
Created attachment 89220 [details]
Add test.
Comment 5 Pavel Podivilov 2011-04-13 09:46:26 PDT 
Committed r83748: <http://trac.webkit.org/changeset/83748>
Comment 6 Jessie Berlin 2011-04-13 15:17:36 PDT 
(In reply to comment #5)
> Committed r83748: <http://trac.webkit.org/changeset/83748>

The new test broke on a bunch of platforms (definitely all the Apple ones).