58216 – Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()

RESOLVED FIXED 58216

Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()

https://bugs.webkit.org/show_bug.cgi?id=58216

Summary Remove safeFloatToInt() in FloatRect.cpp and replace with working version of ...

Simon Fraser (smfr)

Reported 2011-04-10 23:07:27 PDT

In r83422 I attempted to replace the safeFloatToInt() in FloatRect.app with a call to clampToInteger(float), but that gives the wrong result if the input is already INT_MAX.

Attachments
Patch (4.19 KB, patch) 2011-05-23 15:20 PDT, Matthew Delaney	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Matthew Delaney

Comment 1 2011-05-23 15:20:31 PDT

Created attachment 94499 [details] Patch

Matthew Delaney

Comment 2 2011-05-23 15:34:01 PDT

Committed r87103: <http://trac.webkit.org/changeset/87103>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS OS X 10.5

Product WebKit

Component Layout and Rendering

Assignee

Matthew Delaney

Reported

2011-04-10 23:07 PDT

Modified

2011-05-23 15:34 PDT History

CC List

2 users Show

URL

Keywords

Depends on

Blocks

61135

Dependencies

tree graph