WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58213
Enable waf to be used to build other ports
https://bugs.webkit.org/show_bug.cgi?id=58213
Summary
Enable waf to be used to build other ports
Kevin Ollivier
Reported
2011-04-10 21:32:49 PDT
waf is currently only used by wx, but most of the build system logic would work regardless of port, so it'd be nice to make it easier for other ports to try waf out if they so choose.
Attachments
Patch
(51.02 KB, patch)
2011-04-24 15:08 PDT
,
Kevin Ollivier
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kevin Ollivier
Comment 1
2011-04-24 15:08:57 PDT
Created
attachment 90889
[details]
Patch
Kevin Ollivier
Comment 2
2011-04-24 15:12:34 PDT
The patch above does two main things: 1) Moves Tools/wx/build to Tools/waf/build and puts waf in Tools/waf instead of Tools/wx. (90% of the patch, and the reason it's so large.) 2) Turns build_port define into a runtime option, so that you can pass --port="wx" or any other to waf. To make this work, some port-specific logic that was calculated at load time needed to be moved into the configure and build methods. I've tested that the wx port, which is the only port currently using this, builds correctly everywhere we support.
Eric Seidel (no email)
Comment 3
2011-04-26 16:34:24 PDT
Comment on
attachment 90889
[details]
Patch rs=me.
Kevin Ollivier
Comment 4
2011-04-26 18:22:41 PDT
Landed in
r84994
, thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug