Bug 58213 - Enable waf to be used to build other ports
Summary: Enable waf to be used to build other ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Kevin Ollivier
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-10 21:32 PDT by Kevin Ollivier
Modified: 2011-04-26 18:22 PDT (History)
0 users

See Also:

Attachments
Patch (51.02 KB, patch)
2011-04-24 15:08 PDT, Kevin Ollivier 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ollivier 2011-04-10 21:32:49 PDT 
waf is currently only used by wx, but most of the build system logic would work regardless of port, so it'd be nice to make it easier for other ports to try waf out if they so choose.
Comment 1 Kevin Ollivier 2011-04-24 15:08:57 PDT 
Created attachment 90889 [details]
Patch
Comment 2 Kevin Ollivier 2011-04-24 15:12:34 PDT 
The patch above does two main things:

1) Moves Tools/wx/build to Tools/waf/build and puts waf in Tools/waf instead of Tools/wx. (90% of the patch, and the reason it's so large.)

2) Turns build_port define into a runtime option, so that you can pass --port="wx" or any other to waf. To make this work, some port-specific logic that was calculated at load time needed to be moved into the configure and build methods. 

I've tested that the wx port, which is the only port currently using this, builds correctly everywhere we support.
Comment 3 Eric Seidel (no email) 2011-04-26 16:34:24 PDT 
Comment on attachment 90889 [details]
Patch

rs=me.
Comment 4 Kevin Ollivier 2011-04-26 18:22:41 PDT 
Landed in r84994, thanks!