Output parameters such as "redirectResponse" are optional, but do not allow specifying them as such.
Created attachment 88956 [details] Patch
Comment on attachment 88956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88956&action=review > Source/WebCore/inspector/CodeGeneratorInspector.pm:380 > + foreach my $parameter (@argsFiltered) { > + my $optional = $parameter->extendedAttributes->{"optional"} ? "if (" . $parameter->name . ") " : ""; > + push(@function, " " . $optional . "paramsObject->set" . typeTraits($parameter->type, "JSONType") . "(\"" . $parameter->name . "\", " . $parameter->name . ");"); The generated code doesn't match WebKit style guide. > Source/WebCore/inspector/CodeGeneratorInspector.pm:487 > + my $optional = $parameter->extendedAttributes->{"optional"} ? "if (out_" . $parameter->name . ") " : ""; > + push(@function, " " . $optional . "result->set" . typeTraits($parameter->type, "JSONType") . "(\"" . $parameter->name . "\", out_" . $parameter->name . ");"); The code doesn't work well for Array and Object types I'm not sure about strings. The out arguments for array and object types have default values which are not equal to false. generated code doesn't match WebKit style guide.
Created attachment 88980 [details] Patch
Comment on attachment 88980 [details] Patch lgtm
Comment on attachment 88980 [details] Patch Clearing flags on attachment: 88980 Committed r83435: <http://trac.webkit.org/changeset/83435>
All reviewed patches have been landed. Closing bug.