RESOLVED FIXED 58201
REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux. 
https://bugs.webkit.org/show_bug.cgi?id=58201
Summary REGRESSION(r83384): Change to chromium.py is resulting in failures of the tes...
Attachments
Patch (1.52 KB, patch)
2011-04-10 08:53 PDT, David Levin 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-04-10 08:53:53 PDT
Created attachment 88950 [details] Patch
David Levin
Comment 2 2011-04-10 08:55:00 PDT
See dependent bug for the follow up to remove the fixme (and do a better fix).
Dimitri Glazkov (Google)
Comment 3 2011-04-10 08:58:20 PDT
Comment on attachment 88950 [details] Patch ok.
David Levin
Comment 4 2011-04-10 09:01:45 PDT
Committed as http://trac.webkit.org/changeset/83398
Dirk Pranke
Comment 5 2011-04-10 14:28:08 PDT
From looking at the python code implementing subprocess, it looks like either os.waitpid() could be returning something weird, or it could be raising os.error. So, something's definitely wrong, but having NRWT fall over at that point isn't all that useful, so your change is good. I will see if I can follow-up and reproduce it in bug 58202.
Note You need to log in before you can comment on or make changes to this bug.