RESOLVED FIXED 58197
new-run-webkit-tests: fix crash when running under windows cmd.exe 
https://bugs.webkit.org/show_bug.cgi?id=58197
Summary new-run-webkit-tests: fix crash when running under windows cmd.exe
Dirk Pranke
Reported 2011-04-09 20:03:48 PDT
new-run-webkit-tests: fix crash when running under windows cmd.exe
Attachments
Patch (1.78 KB, patch)
2011-04-09 20:05 PDT, Dirk Pranke 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-04-09 20:05:02 PDT
Created attachment 88943 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-04-09 22:13:57 PDT
Comment on attachment 88943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217 > + self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE) Would it be better to use devnull?
Dirk Pranke
Comment 3 2011-04-11 12:27:43 PDT
(In reply to comment #2) > (From update of attachment 88943 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217 > > + self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE) > > Would it be better to use devnull? In limited testing, that does appear to work as well; An advantage to subprocess.PIPE, is that it gets cleaned up automatically when I close the process, which keeps the code slightly cleaner.
Dirk Pranke
Comment 4 2011-04-11 12:32:06 PDT
Committed r83477: <http://trac.webkit.org/changeset/83477>
Dirk Pranke
Comment 5 2011-04-15 15:13:49 PDT
*** Bug 54513 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.