Bug 58197 - new-run-webkit-tests: fix crash when running under windows cmd.exe
Summary: new-run-webkit-tests: fix crash when running under windows cmd.exe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
: 54513 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-04-09 20:03 PDT by Dirk Pranke
Modified: 2011-04-15 15:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2011-04-09 20:05 PDT, Dirk Pranke 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-04-09 20:03:48 PDT 
new-run-webkit-tests: fix crash when running under windows cmd.exe
Comment 1 Dirk Pranke 2011-04-09 20:05:02 PDT 
Created attachment 88943 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-04-09 22:13:57 PDT 
Comment on attachment 88943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review

> Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217
> +        self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE)

Would it be better to use devnull?
Comment 3 Dirk Pranke 2011-04-11 12:27:43 PDT 
(In reply to comment #2)
> (From update of attachment 88943 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217
> > +        self._process = subprocess.Popen(start_cmd, env=env, stdin=subprocess.PIPE)
> 
> Would it be better to use devnull?

In limited testing, that does appear to work as well; An advantage to subprocess.PIPE, is that it gets cleaned up automatically when I close the process, which keeps the code slightly cleaner.
Comment 4 Dirk Pranke 2011-04-11 12:32:06 PDT 
Committed r83477: <http://trac.webkit.org/changeset/83477>
Comment 5 Dirk Pranke 2011-04-15 15:13:49 PDT 
*** Bug 54513 has been marked as a duplicate of this bug. ***