RESOLVED FIXED 58187
Web Inspector: refactor / document call frames in debugger domain.
https://bugs.webkit.org/show_bug.cgi?id=58187
Summary Web Inspector: refactor / document call frames in debugger domain.
Pavel Feldman
Reported 2011-04-09 01:09:18 PDT
Patch to follow. Note that it regresses visual representation a bit: we are not special casing with(element) and with(document) anymore and do not tell user that it is "Event target" and "Event document". However, strictly speaking, we should not have done it for with(element) not necessarily related to an event.
Attachments
Patch (10.78 KB, patch)
2011-04-09 01:21 PDT, Pavel Feldman
no flags
Patch (10.60 KB, patch)
2011-04-11 02:13 PDT, Pavel Feldman
yurys: review+
Pavel Feldman
Comment 1 2011-04-09 01:21:40 PDT
Yury Semikhatsky
Comment 2 2011-04-10 23:40:40 PDT
Comment on attachment 88925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88925&action=review > Source/WebCore/inspector/InjectedScriptSource.js:-513 > - scopeObjectProxy.isElement = true; We should be able to figure it out on the front-end side and avoid the regression. > Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js:100 > + if (scope.type !== "global") { This way you won't expand global scope when it is the only one. This is a regression.
Pavel Feldman
Comment 3 2011-04-11 02:13:11 PDT
Early Warning System Bot
Comment 4 2011-04-11 03:19:16 PDT
Csaba Osztrogonác
Comment 5 2011-04-11 03:52:55 PDT
(In reply to comment #4) > Attachment 88977 [details] did not build on qt: > Build output: http://queues.webkit.org/results/8376824 It was a false positive alarm, sorry for the inconvenience. I fixed the Qt EWS, and tried to build this patch manually, and it works for me. ;)
Pavel Feldman
Comment 6 2011-04-11 04:45:26 PDT
Note You need to log in before you can comment on or make changes to this bug.