Bug 58179 - WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are updated correctly
Summary: WebKit2: Show the substitutions panel on Mac and make sure the menu items tit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-04-08 17:08 PDT by Jessie Berlin
Modified: 2011-04-08 18:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.98 KB, patch)
2011-04-08 17:21 PDT, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-04-08 17:08:32 PDT 
<rdar://problem/9254302>
Comment 1 Jessie Berlin 2011-04-08 17:21:08 PDT 
Created attachment 88905 [details]
Patch
Comment 2 Early Warning System Bot 2011-04-08 17:38:02 PDT 
Attachment 88905 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8376192
Comment 3 Jessie Berlin 2011-04-08 18:17:41 PDT 
(In reply to comment #2)
> Attachment 88905 [details] did not build on qt:
> Build output: http://queues.webkit.org/results/8376192

I guess nested #if do not parse correctly in the messages.in file. I will fix that and commit. Thanks for the review Anders!
Comment 4 Build Bot 2011-04-08 18:34:03 PDT 
Attachment 88905 [details] did not build on win:
Build output: http://queues.webkit.org/results/8379196
Comment 5 Jessie Berlin 2011-04-08 18:40:13 PDT 
Comment on attachment 88905 [details]
Patch

Committed in http://trac.webkit.org/changeset/83369. The build fix in that patch for Qt should also avoid breaking the Win build.