WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58168
Parse 'DispatchOnConnectionQueue' in messages.in files
https://bugs.webkit.org/show_bug.cgi?id=58168
Summary
Parse 'DispatchOnConnectionQueue' in messages.in files
Anders Carlsson
Reported
2011-04-08 15:28:55 PDT
Parse 'DispatchOnConnectionQueue' in messages.in files
Attachments
Patch
(4.41 KB, patch)
2011-04-08 15:29 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-04-08 15:29:54 PDT
Created
attachment 88884
[details]
Patch
Adam Roben (:aroben)
Comment 2
2011-04-08 15:32:21 PDT
Comment on
attachment 88884
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=88884&action=review
> Source/WebKit2/Scripts/webkit2/messages.py:84 > - match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(delayed))?)?', line) > + match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line)
I think you could simplify this: (?:\s+(.*))? to this: (.*)
> Source/WebKit2/Scripts/webkit2/messages_unittest.py:69 > - GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins) > - GetPluginProcessConnection(WTF::String pluginPath) -> (CoreIPC::Connection::Handle connectionHandle) delayed > + GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins) DispatchOnConnectionQueue > + GetPluginProcessConnection(WTF::String pluginPath) -> (CoreIPC::Connection::Handle connectionHandle) Delayed
Would be good to add a test that has more than one attribute.
Anders Carlsson
Comment 3
2011-04-08 15:39:05 PDT
Committed
r83350
: <
http://trac.webkit.org/changeset/83350
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug