Bug 58168 - Parse 'DispatchOnConnectionQueue' in messages.in files
Summary: Parse 'DispatchOnConnectionQueue' in messages.in files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 15:28 PDT by Anders Carlsson
Modified: 2011-04-08 15:39 PDT (History)
0 users

See Also:

Attachments
Patch (4.41 KB, patch)
2011-04-08 15:29 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-04-08 15:28:55 PDT 
Parse 'DispatchOnConnectionQueue' in messages.in files
Comment 1 Anders Carlsson 2011-04-08 15:29:54 PDT 
Created attachment 88884 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-04-08 15:32:21 PDT 
Comment on attachment 88884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88884&action=review

> Source/WebKit2/Scripts/webkit2/messages.py:84
> -            match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(delayed))?)?', line)
> +            match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line)

I think you could simplify this:

(?:\s+(.*))?

to this:

(.*)

> Source/WebKit2/Scripts/webkit2/messages_unittest.py:69
> -    GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins)
> -    GetPluginProcessConnection(WTF::String pluginPath) -> (CoreIPC::Connection::Handle connectionHandle) delayed
> +    GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins) DispatchOnConnectionQueue
> +    GetPluginProcessConnection(WTF::String pluginPath) -> (CoreIPC::Connection::Handle connectionHandle) Delayed

Would be good to add a test that has more than one attribute.
Comment 3 Anders Carlsson 2011-04-08 15:39:05 PDT 
Committed r83350: <http://trac.webkit.org/changeset/83350>