It's nice to be able to enter email address at command line by prepare-ChangeLog --email= option. However when you do the commandline prepare-ChangeLog --help, it did not mention the email option. I think it would be nice to let user know the email option when user use --help. This will improve the usability of prepare-ChangeLog
Created attachment 88874 [details] A patch for review
Attachment 88874 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 88874 [details] A patch for review LGTM except the tab.
I'll try to find tab in the file, BTW, is there any good tool find it? Thanks
(In reply to comment #2) > Attachment 88874 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 > > Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] The style-bot knows all. :)
Created attachment 89056 [details] A new patch that follows the style and without tab
Comment on attachment 89056 [details] A new patch that follows the style and without tab Thank you very much.
Comment on attachment 88874 [details] A patch for review FYI: webkit-patch upload will automatically obsolete previous patches when uploading new ones. (If you chose to use webkit-patch.)
Comment on attachment 89056 [details] A new patch that follows the style and without tab Clearing flags on attachment: 89056 Committed r83546: <http://trac.webkit.org/changeset/83546>
All reviewed patches have been landed. Closing bug.
Thanks Eric, it's good learning for me for the process