Bug 58154 - Add support for comparison operators to the DFG JIT.
Summary: Add support for comparison operators to the DFG JIT.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-04-08 12:51 PDT by Gavin Barraclough
Modified: 2011-04-08 14:16 PDT (History)
1 user (show)

See Also:

The patch, no performance impact. (25.79 KB, patch)
2011-04-08 12:56 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-04-08 12:51:04 PDT
Add support for <, <=, ==, ===, and also !.  Add support for all corresponding bytecode ops, including the not- and -null forms.  Initially add functionally correct support, we'll revisit the performance.
Comment 1 Gavin Barraclough 2011-04-08 12:56:39 PDT
Created attachment 88862 [details]
The patch, no performance impact.
Comment 2 WebKit Review Bot 2011-04-08 12:58:42 PDT
Attachment 88862 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/JavaScriptCore/jit/JITOpcodes.cpp:60:  string_failureCases3 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-04-08 14:16:07 PDT
Fixed in r83337.