Bug 58151 - Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc
Summary: Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Alice Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-08 12:04 PDT by Alice Liu
Modified: 2011-04-08 16:51 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.36 KB, patch)
2011-04-08 12:07 PDT, Alice Liu 		no flags Details | Formatted Diff | Diff
patch with correct changelog (1.82 KB, patch)
2011-04-08 12:11 PDT, Alice Liu 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Liu 2011-04-08 12:04:55 PDT 
On windows, after closing a WebKit2 WebView we can crash in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc.  This is happening because when WebKit2 WebViews close, we aren't removing that webview from the list of WindowMessageBroadcaster listeners.  

<rdar://problem/8779099>
Comment 1 Alice Liu 2011-04-08 12:07:25 PDT 
Created attachment 88855 [details]
patch
Comment 2 WebKit Review Bot 2011-04-08 12:08:14 PDT 
Attachment 88855 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alice Liu 2011-04-08 12:11:45 PDT 
Created attachment 88856 [details]
patch with correct changelog
Comment 4 Adam Roben (:aroben) 2011-04-08 12:55:12 PDT 
Comment on attachment 88856 [details]
patch with correct changelog

Is it possible to make a test for this using TestWebKitAPI? If you know the sequence of events that lead to the crash it should be pretty easy to simulate them in TestWebKitAPI.
Comment 5 Alice Liu 2011-04-08 16:50:25 PDT 
(In reply to comment #4)
I'm unsure if it's possible.  The crash wasn't always reproducible even with the application-specific webview that it was happening with. And my guess is that it's not guaranteed that we'll be able to replicate the situational prerequisites for the crash with TestWebKitAPI, especially if i don't know what they are at the moment.
Comment 6 Alice Liu 2011-04-08 16:51:41 PDT 
http://trac.webkit.org/changeset/83357