RESOLVED FIXED 58146
Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI 
https://bugs.webkit.org/show_bug.cgi?id=58146
Summary Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI
Mikhail Naganov
Reported 2011-04-08 10:46:15 PDT
Tests for Comparsion and Dominators views. Should be enough for now.
Attachments
patch (64.69 KB, patch)
2011-04-08 10:50 PDT, Mikhail Naganov 		pfeldman: review+
mnaganov: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2011-04-08 10:50:06 PDT
Created attachment 88840 [details] patch
Mikhail Naganov
Comment 2 2011-04-12 05:29:35 PDT
Manually committed http://trac.webkit.org/changeset/83581 2011-04-12 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI. https://bugs.webkit.org/show_bug.cgi?id=58146 Tests: inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html inspector/profiler/detailed-heapshots-comparison-show-all.html inspector/profiler/detailed-heapshots-comparison-show-next.html inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html inspector/profiler/detailed-heapshots-comparison-sorting.html inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html inspector/profiler/detailed-heapshots-dominators-show-all.html inspector/profiler/detailed-heapshots-dominators-show-next.html inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html inspector/profiler/detailed-heapshots-dominators-sorting.html inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html * inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotDiffDataGrid): 2011-04-12 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI. https://bugs.webkit.org/show_bug.cgi?id=58146 * inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html: Added. * inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added. * inspector/profiler/detailed-heapshots-comparison-show-all.html: Added. * inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added. * inspector/profiler/detailed-heapshots-comparison-show-next.html: Added. * inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html. * inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-comparison-sorting.html: Added. * inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html: Added. * inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html: Added. * inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added. * inspector/profiler/detailed-heapshots-dominators-show-all.html: Added. * inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt: Added. * inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added. * inspector/profiler/detailed-heapshots-dominators-show-next.html: Added. * inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html: Added. * inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-dominators-sorting.html: Added. * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: * inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added. * inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html. * inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest): * platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added. * platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.
Note You need to log in before you can comment on or make changes to this bug.