Bug 58143 – PerformanceTiming returns inconsistent values when timing is null.

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Vsevolod Vlasov]

PerformanceTiming returns inconsistent values when timing is null.

[Vsevolod Vlasov]

Created attachment 88876 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 88876 [details]
Patch

How do we test this?

[Vsevolod Vlasov]

This is tested in fast/dom/webtiming*.html layout tests.
After landing of http://codereview.chromium.org/6823006/ these tests would fail, unless this patch is also landed.

[Eric Seidel (no email)]

(In reply to comment #3)
> This is tested in fast/dom/webtiming*.html layout tests.
> After landing of http://codereview.chromium.org/6823006/ these tests would fail, unless this patch is also landed.

Ideally the ChagneLog would contain this information. :)

[Pavel Feldman]

Comment on attachment 88876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review

> Source/WebCore/page/PerformanceTiming.cpp:264
> +        return requestStart();

You probably should do the same for the secureConnection timers above and for the responseEnd below.

[Vsevolod Vlasov]

Comment on attachment 88876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review

>> Source/WebCore/page/PerformanceTiming.cpp:264
>> +        return requestStart();
> 
> You probably should do the same for the secureConnection timers above and for the responseEnd below.

secureConnection: "If this attribute is available but HTTPS is not used, this attribute must return zero.", so zero is correct.
respondEnd is filled from documentLoadTiming, not resourceLoadTiming, so its value is correct as well.

[Tony Gentilcore]

Thanks for taking care of this.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 88876 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 88876 [details]
Patch

Clearing flags on attachment: 88876

Committed r83491: <http://trac.webkit.org/changeset/83491>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.