Bug 58128 – -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Maciej Stachowiak]

-[WebView setPreferences:] can take a lot of time if loading lots of webviews at once

[Maciej Stachowiak]

Created attachment 88788 [details]
Patch

[Darin Adler]

Comment on attachment 88788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88788&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:1189
> +    [[NSNotificationCenter defaultCenter]
> +        postNotificationName:WebPreferencesChangedInternalNotification object:self
> +                    userInfo:nil];
> +    [[NSNotificationCenter defaultCenter]
> +        postNotificationName:WebPreferencesChangedNotification object:self
> +                    userInfo:nil];

I don’t like lining these up. Probably would read better all on one line.

> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:54
> +extern NSString *WebPreferencesChangedInternalNotification;

If this is an internal notification then it should probably be in an internal header, not a private header.

> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:215
> -- (void)_postPreferencesChangesNotification;
> +- (void)_postPreferencesChangedNotification;
> +- (void)_postPreferencesChangedAPINotification;

If these are private methods they may be used in applications that make use of SPI. Can we really rename them safely?

If these are internal methods they should be in an internal header, not a private one.

[Maciej Stachowiak]

(In reply to comment #2)
> (From update of attachment 88788 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88788&action=review
> 
> > Source/WebKit/mac/WebView/WebPreferences.mm:1189
> > +    [[NSNotificationCenter defaultCenter]
> > +        postNotificationName:WebPreferencesChangedInternalNotification object:self
> > +                    userInfo:nil];
> > +    [[NSNotificationCenter defaultCenter]
> > +        postNotificationName:WebPreferencesChangedNotification object:self
> > +                    userInfo:nil];
> 
> I don’t like lining these up. Probably would read better all on one line.

I just copied what the code was already doing. But I agree, will make it one line.

> 
> > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:54
> > +extern NSString *WebPreferencesChangedInternalNotification;
> 
> If this is an internal notification then it should probably be in an internal header, not a private header.
> 
> > Source/WebKit/mac/WebView/WebPreferencesPrivate.h:215
> > -- (void)_postPreferencesChangesNotification;
> > +- (void)_postPreferencesChangedNotification;
> > +- (void)_postPreferencesChangedAPINotification;
> 
> If these are private methods they may be used in applications that make use of SPI. Can we really rename them safely?
> 
> If these are internal methods they should be in an internal header, not a private one.

There isn't currently a WebPreferencesInternal.h header, and existing internal (rather than private) methods are in the private header. Should I factor out an Internal header as part of this change, or separately?

[Maciej Stachowiak]

Committed r83324: <http://trac.webkit.org/changeset/83324>