Bug 58124 - Web Inspector: HAR compliance fixes
Summary: Web Inspector: HAR compliance fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 02:11 PDT by Andrey Kosyakov
Modified: 2011-05-13 06:48 PDT (History)
12 users (show)

See Also:

Attachments
patch (22.92 KB, patch)
2011-04-08 02:22 PDT, Andrey Kosyakov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-04-08 02:11:02 PDT 
Small batch of fixes for HAR standard compliance:
- Always provide some values for queryString and cookies, even though arrays may be empty
- Always provide an empty cache object
- Added entire HARLog to test
- Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)
Comment 1 Andrey Kosyakov 2011-04-08 02:22:54 PDT 
Created attachment 88784 [details]
patch
Comment 2 Yury Semikhatsky 2011-04-08 02:27:44 PDT 
Comment on attachment 88784 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88784&action=review

> Source/WebCore/inspector/front-end/HAREntry.js:48
> +            cache: { }, // Not supproted yet.

Please file a bug on this and add a FIXME here.
Comment 3 Andrey Kosyakov 2011-04-08 02:56:01 PDT 
Added FIXME, filed bug 58127 for other missing fields.

Manually committed r83275: http://trac.webkit.org/changeset/83275
Comment 4 WebKit Review Bot 2011-04-08 03:21:06 PDT 
http://trac.webkit.org/changeset/83275 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-parameters.html