Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.

[Pavel Feldman]

This change reuses location for call frames in the protocol + structures script location <-> source lines interaction better. When we need UI columns, we will add them, but we should distinguish between script and UI terms on the type level, not naming.

[Pavel Feldman]

Created attachment 88774 [details]
[PATCH] Work in progress, need to check tests.

[Pavel Feldman]

Created attachment 88791 [details]
Patch

[Pavel Podivilov]

Comment on attachment 88791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88791&action=review

Looks good.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:391
>              {

didGetSourceLine here and below.

[Build Bot]

Attachment 88791 [details] did not build on win:
Build output: http://queues.webkit.org/results/8373494

[Pavel Podivilov]

Comment on attachment 88791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88791&action=review

> Source/WebCore/inspector/front-end/CallStackSidebarPane.js:-68
> -                subtitle = WebInspector.UIString("(internal script)");

This should not have changed.

[Pavel Feldman]

Created attachment 88802 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 88802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88802&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:182
> +        // FIXME: replace with input validation.

Please file a bug and put its number next to the FIXME

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:225
> +    if (!location->getString("sourceID", &sourceId) || !location->getNumber("lineNumber", &lineNumber)) {

This code repeats twice, consider extracting a method.

[Pavel Feldman]

Committed r83290: <http://trac.webkit.org/changeset/83290>

[Build Bot]

Attachment 88802 [details] did not build on win:
Build output: http://queues.webkit.org/results/8342921