RESOLVED FIXED Bug 58118
Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements. 
https://bugs.webkit.org/show_bug.cgi?id=58118
Summary Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI...
Pavel Feldman
Reported 2011-04-07 23:57:33 PDT
This change reuses location for call frames in the protocol + structures script location <-> source lines interaction better. When we need UI columns, we will add them, but we should distinguish between script and UI terms on the type level, not naming.
Attachments
[PATCH] Work in progress, need to check tests. (20.20 KB, patch)
2011-04-07 23:59 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (33.74 KB, patch)
2011-04-08 03:32 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (33.14 KB, patch)
2011-04-08 05:19 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-04-07 23:59:32 PDT
Created attachment 88774 [details] [PATCH] Work in progress, need to check tests.
Pavel Feldman
Comment 2 2011-04-08 03:32:47 PDT
Created attachment 88791 [details] Patch
Pavel Podivilov
Comment 3 2011-04-08 04:02:46 PDT
Comment on attachment 88791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88791&action=review Looks good. > Source/WebCore/inspector/front-end/ScriptsPanel.js:391 > { didGetSourceLine here and below.
Build Bot
Comment 4 2011-04-08 04:18:26 PDT
Attachment 88791 [details] did not build on win: Build output: http://queues.webkit.org/results/8373494
Pavel Podivilov
Comment 5 2011-04-08 05:07:07 PDT
Comment on attachment 88791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88791&action=review > Source/WebCore/inspector/front-end/CallStackSidebarPane.js:-68 > - subtitle = WebInspector.UIString("(internal script)"); This should not have changed.
Pavel Feldman
Comment 6 2011-04-08 05:19:31 PDT
Created attachment 88802 [details] Patch
Yury Semikhatsky
Comment 7 2011-04-08 05:24:49 PDT
Comment on attachment 88802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88802&action=review > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:182 > + // FIXME: replace with input validation. Please file a bug and put its number next to the FIXME > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:225 > + if (!location->getString("sourceID", &sourceId) || !location->getNumber("lineNumber", &lineNumber)) { This code repeats twice, consider extracting a method.
Pavel Feldman
Comment 8 2011-04-08 05:37:14 PDT
Committed r83290: <http://trac.webkit.org/changeset/83290>
Build Bot
Comment 9 2011-04-08 05:47:22 PDT
Attachment 88802 [details] did not build on win: Build output: http://queues.webkit.org/results/8342921
Note You need to log in before you can comment on or make changes to this bug.