Bug 58118 - Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
Summary: Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 23:57 PDT by Pavel Feldman
Modified: 2011-04-08 05:47 PDT (History)
11 users (show)

See Also:


Attachments
[PATCH] Work in progress, need to check tests. (20.20 KB, patch)
2011-04-07 23:59 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (33.74 KB, patch)
2011-04-08 03:32 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (33.14 KB, patch)
2011-04-08 05:19 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-07 23:57:33 PDT
This change reuses location for call frames in the protocol + structures script location <-> source lines interaction better. When we need UI columns, we will add them, but we should distinguish between script and UI terms on the type level, not naming.
Comment 1 Pavel Feldman 2011-04-07 23:59:32 PDT
Created attachment 88774 [details]
[PATCH] Work in progress, need to check tests.
Comment 2 Pavel Feldman 2011-04-08 03:32:47 PDT
Created attachment 88791 [details]
Patch
Comment 3 Pavel Podivilov 2011-04-08 04:02:46 PDT
Comment on attachment 88791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88791&action=review

Looks good.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:391
>              {

didGetSourceLine here and below.
Comment 4 Build Bot 2011-04-08 04:18:26 PDT
Attachment 88791 [details] did not build on win:
Build output: http://queues.webkit.org/results/8373494
Comment 5 Pavel Podivilov 2011-04-08 05:07:07 PDT
Comment on attachment 88791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88791&action=review

> Source/WebCore/inspector/front-end/CallStackSidebarPane.js:-68
> -                subtitle = WebInspector.UIString("(internal script)");

This should not have changed.
Comment 6 Pavel Feldman 2011-04-08 05:19:31 PDT
Created attachment 88802 [details]
Patch
Comment 7 Yury Semikhatsky 2011-04-08 05:24:49 PDT
Comment on attachment 88802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88802&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:182
> +        // FIXME: replace with input validation.

Please file a bug and put its number next to the FIXME

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:225
> +    if (!location->getString("sourceID", &sourceId) || !location->getNumber("lineNumber", &lineNumber)) {

This code repeats twice, consider extracting a method.
Comment 8 Pavel Feldman 2011-04-08 05:37:14 PDT
Committed r83290: <http://trac.webkit.org/changeset/83290>
Comment 9 Build Bot 2011-04-08 05:47:22 PDT
Attachment 88802 [details] did not build on win:
Build output: http://queues.webkit.org/results/8342921