WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58117
Incoming source should be preload scanned when the parser is blocked
https://bugs.webkit.org/show_bug.cgi?id=58117
Summary
Incoming source should be preload scanned when the parser is blocked
Antti Koivisto
Reported
2011-04-07 23:18:43 PDT
Currently we append to the scanner but don't actually scan.
Attachments
patch
(4.89 KB, patch)
2011-04-08 00:46 PDT
,
Antti Koivisto
tonyg
: review+
tonyg
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2011-04-08 00:46:14 PDT
Created
attachment 88781
[details]
patch
Adam Barth
Comment 2
2011-04-08 00:59:38 PDT
Comment on
attachment 88781
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=88781&action=review
> LayoutTests/ChangeLog:-9650 > ->>>>>>> .
r82178
This change looks suspicious. :)
> LayoutTests/http/tests/loading/preload-append-scan.php:18 > +usleep(200000);
Does this test really take 20 seconds to run?
Adam Barth
Comment 3
2011-04-08 01:00:11 PDT
tonyg, would you be willing to review this patch?
Antti Koivisto
Comment 4
2011-04-08 01:14:40 PDT
(In reply to
comment #2
)
> > +usleep(200000); > > Does this test really take 20 seconds to run?
200ms
Adam Barth
Comment 5
2011-04-08 01:15:28 PDT
> 200ms
I'm really too tired to be commenting in bugs. :)
Tony Gentilcore
Comment 6
2011-04-08 09:04:05 PDT
Comment on
attachment 88781
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=88781&action=review
This looks good, but we are starting to get a lot of entry points for scanning. I'm wondering if we shouldn't fix
bug 57376
, then always kick off the preload scanner first thing in insert() and append() (and nowhere else).
> LayoutTests/http/tests/resources/slow-script.pl:1 > +#!/usr/bin/perl -w
Is it possible to avoid adding a new resource and instead reuse misc/resources/script-slow1.pl?
Antti Koivisto
Comment 7
2011-04-08 11:57:32 PDT
http://trac.webkit.org/changeset/83321
WebKit Review Bot
Comment 8
2011-04-08 12:47:29 PDT
http://trac.webkit.org/changeset/83321
might have broken Qt Linux Release The following tests are not passing: http/tests/loading/preload-append-scan.php
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug