Bug 58110 - [Chromium] Remove unneeded usage of V8::Lockers in IDB tests.
Summary: [Chromium] Remove unneeded usage of V8::Lockers in IDB tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 18:24 PDT by Dmitry Titov
Modified: 2011-04-08 13:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch. (1.24 KB, patch)
2011-04-07 18:31 PDT, Dmitry Titov
abarth: review+
dimich: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2011-04-07 18:24:28 PDT
Since webkit_unit_tests are not running v8 on multiple threads, there is no need to use v8::Locker class.
The problem with using it once is that every other test that runs late in the same process has to acquire a v8 lock too. Tests normally do not do that so they fail, especially on randomized runs.

This will make the patch in bug 58096 not needed.
Comment 1 Dmitry Titov 2011-04-07 18:31:13 PDT
Created attachment 88751 [details]
Patch.
Comment 2 Dmitry Titov 2011-04-08 13:11:23 PDT
Landed: http://trac.webkit.org/changeset/83331