Bug 58095 - [GTK] Fix the WebKit2 build for older versions of GTK+
Summary: [GTK] Fix the WebKit2 build for older versions of GTK+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-04-07 15:56 PDT by Martin Robinson
Modified: 2011-04-08 12:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.71 KB, patch)
2011-04-08 11:35 PDT, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-04-07 15:56:43 PDT 
WebKit2 uses gdk_window_create_similar_surface which is only availabe in GTK+ >= 2.22.
Comment 1 Martin Robinson 2011-04-08 11:35:36 PDT 
Created attachment 88845 [details]
Patch
Comment 2 Xan Lopez 2011-04-08 11:38:11 PDT 
Comment on attachment 88845 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2011-04-08 11:39:00 PDT 
Attachment 88845 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/gtk/GtkVersioning.h:50:  The parameter name "window" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/gtk/GtkVersioning.h:50:  The parameter name "content" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/gtk/GtkVersioning.h:50:  gdk_window_create_similar_surface is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Martin Robinson 2011-04-08 11:48:09 PDT 
Committed r83319: <http://trac.webkit.org/changeset/83319>
Comment 5 WebKit Review Bot 2011-04-08 12:47:20 PDT 
http://trac.webkit.org/changeset/83319 might have broken Qt Linux Release
The following tests are not passing:
http/tests/loading/preload-append-scan.php