Bug 58085 - Logic error in HTMLMediaElement::exitFullscreen()
Summary: Logic error in HTMLMediaElement::exitFullscreen()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2011-04-07 14:55 PDT by Jer Noble
Modified: 2011-04-08 13:12 PDT (History)
2 users (show)

See Also:

Patch (2.20 KB, patch)
2011-04-07 15:03 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2011-04-07 16:44 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-04-07 14:55:27 PDT
If a script calls exitFullscreen() on an element which is not the current full screen element, it will hit the ASSERT in the legacy full screen media case.
Comment 1 Jer Noble 2011-04-07 14:58:45 PDT
Comment 2 Jer Noble 2011-04-07 15:03:31 PDT
Created attachment 88710 [details]
Comment 3 WebKit Review Bot 2011-04-07 16:09:39 PDT
Attachment 88710 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8342680
Comment 4 Jer Noble 2011-04-07 16:44:29 PDT
Created attachment 88733 [details]

Missing parenthesis reinserted.
Comment 5 Jer Noble 2011-04-08 13:12:16 PDT
Committed r83332: <http://trac.webkit.org/changeset/83332>