Bug 58084 - [CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
Summary: [CG] Refactor get/putImageData routines from ImageBufferCG into a (new) Image...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks: 58088
  Show dependency tree / graph
 
Reported: 2011-04-07 14:52 PDT by Matthew Delaney
Modified: 2011-04-13 16:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (31.16 KB, patch)
2011-04-08 11:40 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Patch (31.20 KB, patch)
2011-04-08 15:45 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Patch (68.47 KB, patch)
2011-04-13 16:05 PDT, Matthew Delaney 		no flags Details | Formatted Diff | Diff
Patch (67.75 KB, patch)
2011-04-13 16:29 PDT, Matthew Delaney 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2011-04-07 14:52:48 PDT 
The routines for getting/putting image data from/to the ImageBuffer's backing store are solely tied to that backing store and are also getting a bit complicated. It makes sense to create an ImageBufferData.cpp to house this logic.
Comment 1 Matthew Delaney 2011-04-08 11:40:20 PDT 
Created attachment 88846 [details]
Patch
Comment 2 Matthew Delaney 2011-04-08 15:31:02 PDT 
EWS bots likely couldn't patch because of the xcodeproj file changing in the interim. I'm going to try again on the EWS bots by uploading the same patch again (after an update). If they just fail again (likely), I'll give it a run this evening when traffic is hopefully slower. I'm unsure of the project file changes needed for other projects and am pretty sure that the refactoring may need extra changes on other projects anyhow.
Comment 3 Matthew Delaney 2011-04-08 15:45:59 PDT 
Created attachment 88887 [details]
Patch
Comment 4 WebKit Review Bot 2011-04-08 16:26:39 PDT 
Attachment 88887 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8377184
Comment 5 Matthew Delaney 2011-04-13 16:05:03 PDT 
Created attachment 89485 [details]
Patch
Comment 6 Matthew Delaney 2011-04-13 16:29:08 PDT 
Created attachment 89490 [details]
Patch
Comment 7 Simon Fraser (smfr) 2011-04-13 16:36:09 PDT 
Comment on attachment 89490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89490&action=review

> Source/WebCore/platform/graphics/ImageBufferData.h:44
> +#if (PLATFORM(MAC) && PLATFORM(CA) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD))
> +#define WTF_USE_IOSURFACE_CANVAS_BACKING_STORE 1
> +#endif

Shouldn't this be in ImageBufferCG.h?
Comment 8 Matthew Delaney 2011-04-13 16:39:50 PDT 
> > +#if (PLATFORM(MAC) && PLATFORM(CA) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD))
> > +#define WTF_USE_IOSURFACE_CANVAS_BACKING_STORE 1
> > +#endif
> 
> Shouldn't this be in ImageBufferCG.h?

It was in ImageBuffer.h because it was need there and below. I suppose since it's more specific to CG land and it wouldn't hurt, I'll just move it to ImageBufferCG.h.
Comment 9 Matthew Delaney 2011-04-13 16:49:46 PDT 
Committed r83786: <http://trac.webkit.org/changeset/83786>