Bug 58081 – dump-as-markup conversion: editing/pasteboard/paste-text-at-tabspan-001.html and paste-text-at-tabspan-002.html

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

The following two tests should be converted to dump-as-markup tests so that the output can easily be understood:
editing/pasteboard/paste-text-at-tabspan-001.html
editing/pasteboard/paste-text-at-tabspan-002.html

[Ryosuke Niwa]

Created attachment 88707 [details]
Patch

[Tony Chang]

Comment on attachment 88707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88707&action=review

> LayoutTests/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:25
> +You should see aa\tz below:
> +| "
> +"
> +| <span>
> +|   id="test"
> +|   "a"
> +|   <span>
> +|     class="Apple-tab-span"
> +|     style="white-space:pre"
> +|     "a"
> +|     "			"
> +|   "x<#selection-caret>"
> +|   "z"

It looks like it's aa\txz, no?

> LayoutTests/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:15
> +You should see a\tax\t\tz below:

This one looks like a\ta\t\txz.

[Ryosuke Niwa]

Comment on attachment 88707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88707&action=review

>> LayoutTests/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:25

> 
> It looks like it's aa\txz, no?

Oops, this should be "aax\tz".  There's currently a bug in this text. After pasting "a" before the tab, typing x will insert x after the tab.

>> LayoutTests/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:15
>> +You should see a\tax\t\tz below:
> 
> This one looks like a\ta\t\txz.

It's a regression :(

[Ryosuke Niwa]

Created attachment 88770 [details]
fixed 'aa\txz' to 'aax\tz'

[Ryosuke Niwa]

So I investigated a little on why this had never been detected by the existing test, and found out that the bug does not reproduce when div had a style such as style="border: 2px solid red; padding: 12px; font-size: 24px".  I'm uploading a new patch that adds style so as to preserve the original test and also filing a bug about this.

[Ryosuke Niwa]

Created attachment 88794 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 88794 [details]
Patch

Clearing flags on attachment: 88794

Committed r83343: <http://trac.webkit.org/changeset/83343>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.